Eliminate AutofillWebDataService::FromBrowserContext().

chrome/browser/webdata/web_data_service_factory.h

Index: chrome/browser/webdata/web_data_service_factory.h
diff --git a/chrome/browser/webdata/web_data_service_factory.h b/chrome/browser/webdata/web_data_service_factory.h
index cb80c23be977fb5b5e37df87dda74454c8f8434d..bef2bd8da869f3a52c66440e754e50ef55f63e77 100644
--- a/chrome/browser/webdata/web_data_service_factory.h
+++ b/chrome/browser/webdata/web_data_service_factory.h
@@ -62,6 +62,10 @@ class WebDataServiceFactory : public BrowserContextKeyedServiceFactory {
   static WebDataServiceWrapper* GetForProfileIfExists(
       Profile* profile, Profile::ServiceAccessType access_type);
 
+  // Returns the |AutofillWebDataService| associated with the |profile|.
+  static scoped_refptr<autofill::AutofillWebDataService>
+      GetAutofillWebDataForProfile(Profile* profile);

[Peter Kasting, 2013/11/15 01:30:59]

This seems like a random place for this.  Why wouldn't this be a static method
on either AutofillWebDataService?

[Peter Kasting, 2013/11/15 01:35:59]

Belay that, I should learn to read your comments first.

Two followup questions:
(1) Should this be on WebDataServiceWrapper instead, since that's really the
class that owns this?
(2) Can we at least add a comment as to why this isn't defined on
AutofillWebDataService itself?

I am still uneasy about this path overall.  It seems like this should live on
something more directly autofill-related, but I don't know what that might be.

[blundell, 2013/11/19 14:05:37]

(1) Via discussion on this review thread, resolved that this location is
actually the most appropriate place for this getter.
(2) Comment added.

On 2013/11/15 01:35:59, Peter Kasting wrote:

+
   static WebDataServiceFactory* GetInstance();
 
  private: