android_webview/native/aw_autofill_manager_delegate.cc - Issue 72613006: Eliminate AutofillWebDataService::FromBrowserContext().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_autofill_manager_delegate.cc

Issue 72613006: Eliminate AutofillWebDataService::FromBrowserContext(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_autofill_manager_delegate.cc

diff --git a/android_webview/native/aw_autofill_manager_delegate.cc b/android_webview/native/aw_autofill_manager_delegate.cc

index 06eec05314185d14ddc13c74a71a802d845697bb..5dad2accfc54566507c4a5618b276a61259f7666 100644

--- a/android_webview/native/aw_autofill_manager_delegate.cc

+++ b/android_webview/native/aw_autofill_manager_delegate.cc

@@ -6,6 +6,7 @@

#include "android_webview/browser/aw_browser_context.h"

#include "android_webview/browser/aw_content_browser_client.h"

+#include "android_webview/browser/aw_form_database_service.h"

#include "android_webview/browser/aw_pref_store.h"

#include "android_webview/native/aw_contents.h"

#include "base/android/jni_android.h"

@@ -73,8 +74,11 @@ AwAutofillManagerDelegate::GetPersonalDataManager() {

scoped_refptr<autofill::AutofillWebDataService>

AwAutofillManagerDelegate::GetDatabase() {

- return autofill::AutofillWebDataService::FromBrowserContext(

- web_contents_->GetBrowserContext());

+ android_webview::AwFormDatabaseService* service =

+ static_cast<android_webview::AwBrowserContext*>(

+ web_contents_->GetBrowserContext())->GetFormDatabaseService();

+ DCHECK(service);

Ilya Sherman 2013/11/14 23:54:33 nit: This is redundant with just making a method c

blundell 2013/11/19 14:05:37 Done.

+ return service->get_autofill_webdata_service();

}

void AwAutofillManagerDelegate::ShowAutofillPopup(