Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 726123002: Ensure invalidation of non-composited scrollbars on resize (Closed)

Created:
6 years, 1 month ago by Xianzhu
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Ensure invalidation of non-composited scrollbars on resize When a scrollable area is resized, scrollbars will be relocated. The original scrollbar damage logic doesn't always cover the case because the properties of the scrollbars may be unchanged. We could let incremental invalidation cover scrollbars, but just do a full invalidation if there are any non-composited scrollbars because incremental invalidation will go away with slimming paint. BUG=430053 TEST=fast/repaint/scrollbar-invalidation-on-resize.html TEST=fast/repaint/scrollbar-invalidation-on-resize-with-border.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
A LayoutTests/fast/repaint/scrollbar-invalidation-on-resize.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-with-border.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-with-border-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 4 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Xianzhu
6 years, 1 month ago (2014-11-15 00:01:51 UTC) #2
dsinclair
lgtm
6 years, 1 month ago (2014-11-17 14:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726123002/1
6 years, 1 month ago (2014-11-17 14:50:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 17:15:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185456

Powered by Google App Engine
This is Rietveld 408576698