Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 726093002: Add irt_random to szbuild link line. (Closed)

Created:
6 years, 1 month ago by jvoung (off chromium)
Modified:
6 years, 1 month ago
Reviewers:
kschimpf, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add irt_random to szbuild link line. Seems to be part of the non-sfi link now: https://codereview.chromium.org/686723003/diff/180001/pnacl/driver/pnacl-translate.py Otherwise I get: x86-32-linux/lib/unsandboxed_irt.o:(.rodata+0x68): undefined reference to `nacl_secure_random' BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=edc115ec12829b3daea95ecad4a49f72e1de5666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pydir/szbuild.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
6 years, 1 month ago (2014-11-14 21:28:27 UTC) #2
Jim Stichnoth
lgtm
6 years, 1 month ago (2014-11-14 21:30:18 UTC) #3
jvoung (off chromium)
6 years, 1 month ago (2014-11-14 21:50:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edc115ec12829b3daea95ecad4a49f72e1de5666 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698