src/ports/SkFontHost_win.cpp - Issue 72603005: Guard against most unintentionally ephemeral SkAutoFoo instantiations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_win.cpp

Issue 72603005: Guard against most unintentionally ephemeral SkAutoFoo instantiations. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: docs and REQUIRE_LOCAL_VAR Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_win.cpp

diff --git a/src/ports/SkFontHost_win.cpp b/src/ports/SkFontHost_win.cpp

index be762eead364549330f5e4028971a278c9b4f697..7416cb22fa558fd99c9081759e5c10a80eed191e 100755

--- a/src/ports/SkFontHost_win.cpp

+++ b/src/ports/SkFontHost_win.cpp

@@ -2153,6 +2153,7 @@ private:

HFONT fFont;

HFONT fSavefont;

};

+#define SkAutoHDC(...) SK_REQUIRE_LOCAL_VAR(SkAutoHDC)

int LogFontTypeface::onCharsToGlyphs(const void* chars, Encoding encoding,

uint16_t userGlyphs[], int glyphCount) const