include/core/SkThread.h - Issue 72603005: Guard against most unintentionally ephemeral SkAutoFoo instantiations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/core/SkThread.h

Issue 72603005: Guard against most unintentionally ephemeral SkAutoFoo instantiations. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: docs and REQUIRE_LOCAL_VAR Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright 2006 The Android Open Source Project	3 * Copyright 2006 The Android Open Source Project

4 *	4 *

5 * Use of this source code is governed by a BSD-style license that can be	5 * Use of this source code is governed by a BSD-style license that can be

6 * found in the LICENSE file.	6 * found in the LICENSE file.

7 */	7 */

8	8

9	9

10 #ifndef SkThread_DEFINED	10 #ifndef SkThread_DEFINED

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 void release() {	57 void release() {

58 if (fMutex) {	58 if (fMutex) {

59 fMutex->release();	59 fMutex->release();

60 fMutex = NULL;	60 fMutex = NULL;

61 }	61 }

62 }	62 }

63	63

64 private:	64 private:

65 SkBaseMutex* fMutex;	65 SkBaseMutex* fMutex;

66 };	66 };

	67 #define SkAutoMutexAcquire(...) SK_REQUIRE_LOCAL_VAR(SkAutoMutexAcquire)

67	68

68 #endif	69 #endif

OLD	NEW