Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java

Issue 726013002: [Cronet] Hook up library loader, system proxy and network change notifier to async api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self review, cl format Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java
diff --git a/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java b/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java
index 094b388559e13043f9dbc403421515e8200c499c..d99e8440eb8409a030cd36518051a78d940c0412 100644
--- a/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java
+++ b/components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java
@@ -34,7 +34,16 @@ public class CronetTestActivity extends Activity {
public static final String COMMAND_LINE_ARGS_KEY = "commandLineArgs";
public static final String POST_DATA_KEY = "postData";
public static final String CONFIG_KEY = "config";
- public static final String SKIP_FACTORY_INIT_KEY = "skipFactoryInit";
+ public static final String LIBRARY_INIT_KEY = "libraryInit";
+ /**
+ * Skip library initialization.
+ */
+ public static final String LIBRARY_INIT_SKIP = "skip";
+
+ /**
+ * Initialize Cronet Async API only.
+ */
+ public static final String LIBRARY_INIT_CRONET_ONLY = "cronetOnly";
public CronetURLStreamHandlerFactory mStreamHandlerFactory;
@@ -67,22 +76,20 @@ public class CronetTestActivity extends Activity {
protected void onCreate(final Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
- try {
- System.loadLibrary("cronet_tests");
- } catch (UnsatisfiedLinkError e) {
- Log.e(TAG, "libcronet_test initialization failed.", e);
- finish();
+ String initString = getCommandLineArg(LIBRARY_INIT_KEY);
+ if (LIBRARY_INIT_SKIP.equals(initString)) {
return;
}
- String skipInitString = getCommandLineArg(SKIP_FACTORY_INIT_KEY);
- if (skipInitString != null) {
- return;
- }
- mRequestFactory = initRequestFactory();
+ mUrlRequestContext = initRequestContext();
mStreamHandlerFactory = new CronetURLStreamHandlerFactory(
getApplicationContext(), null);
+ if (LIBRARY_INIT_CRONET_ONLY.equals(initString)) {
+ return;
+ }
+
+ mRequestFactory = initRequestFactory();
if (mRequestFactory == null) {
return;
}
@@ -93,8 +100,7 @@ public class CronetTestActivity extends Activity {
}
}
- // Helper function to initialize request factory. Also used in testing.
- public HttpUrlRequestFactory initRequestFactory() {
+ UrlRequestContextConfig getContextConfig() {
UrlRequestContextConfig config = new UrlRequestContextConfig();
config.enableHttpCache(UrlRequestContextConfig.HttpCache.IN_MEMORY,
100 * 1024)
@@ -116,12 +122,17 @@ public class CronetTestActivity extends Activity {
// Setting this here so it isn't overridden on the command line
config.setLibraryName("cronet_tests");
+ return config;
+ }
- mUrlRequestContext = UrlRequestContext.createContext(
- getApplicationContext(), config);
+ // Helper function to initialize request context. Also used in testing.
+ public UrlRequestContext initRequestContext() {
+ return UrlRequestContext.createContext(getApplicationContext(), getContextConfig());
+ }
- return HttpUrlRequestFactory.createFactory(getApplicationContext(),
- config);
+ // Helper function to initialize request factory. Also used in testing.
+ public HttpUrlRequestFactory initRequestFactory() {
+ return HttpUrlRequestFactory.createFactory(getApplicationContext(), getContextConfig());
}
private static String getUrlFromIntent(Intent intent) {

Powered by Google App Engine
This is Rietveld 408576698