components/cronet/android/cronet_url_request_adapter.cc - Issue 726013002: [Cronet] Hook up library loader, system proxy and network change notifier to async api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 726013002: [Cronet] Hook up library loader, system proxy and network change notifier to async api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the deadlock. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.h ('k') | components/cronet/android/cronet_url_request_context.cc » ('j') | components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc

index 265895af4512a5ab4f932c5d8e4d9a1942f6799e..14e54c76ee69534b01c6b824ff6391914b570408 100644

--- a/components/cronet/android/cronet_url_request_adapter.cc

+++ b/components/cronet/android/cronet_url_request_adapter.cc

@@ -41,15 +41,15 @@ void CronetURLRequestAdapter::AddRequestHeader(const std::string& name,

initial_request_headers_.SetHeader(name, value);

}

-bool CronetURLRequestAdapter::PostTaskToNetworkThread(

+void CronetURLRequestAdapter::PostTaskToNetworkThread(

const tracked_objects::Location& from_here,

const base::Closure& task) {

DCHECK(!IsOnNetworkThread());

- return context_->GetNetworkTaskRunner()->PostTask(from_here, task);

+ context_->PostTaskToNetworkThread(from_here, task);

}

bool CronetURLRequestAdapter::IsOnNetworkThread() const {

- return context_->GetNetworkTaskRunner()->BelongsToCurrentThread();

+ return context_->IsOnNetworkThread();

}

void CronetURLRequestAdapter::Start() {