Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 725993003: Change test type of flakiness dashboard uploads to match buildbot step name. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, vtl, jamesr
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Change test type of flakiness dashboard uploads to match buildbot step name. Flakiness dashboard assumed each buildbot step corresponds to one test suite. So, it assumes the test type matches the buildbot step name. This fix is somewhat hacky in that we won't be able to make other test suites in mojob test upload to the flakiness dashboard, but that's technical debt we already have from smashing multiple test suites into one buildbot step. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/43b883193c5d02b8d6cb26f076ec1b60bc9195f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/tools/webkitpy/layout_tests/controllers/manager.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
6 years, 1 month ago (2014-11-19 19:00:51 UTC) #2
eseidel
lgtm Recipes makes it trivial to split out into many steps... But OK.
6 years, 1 month ago (2014-11-19 19:17:58 UTC) #3
ojan
Committed patchset #1 (id:1) manually as 43b883193c5d02b8d6cb26f076ec1b60bc9195f6 (presubmit successful).
6 years, 1 month ago (2014-11-19 20:26:57 UTC) #4
ojan
6 years, 1 month ago (2014-11-19 20:31:12 UTC) #5
Message was sent while issue was closed.
On 2014/11/19 at 19:17:58, eseidel wrote:
> Recipes makes it trivial to split out into many steps... But OK.

I don't know the history of why we are doing it as a single step.
trung/jamesr/abarth can comment on that.

In either case, we don't want these uploading as layout-tests, so we need to
change this. Once we split out to separate steps, we'll need to change this
again to match the new step name, but that's trivial.

Anyways, if you want to make that happen, go for it.

Powered by Google App Engine
This is Rietveld 408576698