Make sure new maximized window gets activated

ui/views/win/hwnd_message_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/win/hwnd_message_handler.h"
 
 #include <dwmapi.h>
 #include <oleacc.h>
 #include <shellapi.h>
 #include <wtsapi32.h>
@@ skipping 580 matching lines @@
   switch (show_state) {
     case ui::SHOW_STATE_INACTIVE:
       native_show_state = SW_SHOWNOACTIVATE;
       break;
     case ui::SHOW_STATE_MAXIMIZED:
       native_show_state = SW_SHOWMAXIMIZED;
       break;
     case ui::SHOW_STATE_MINIMIZED:
       native_show_state = SW_SHOWMINIMIZED;
       break;
+    case ui::SHOW_STATE_NORMAL:
+      native_show_state = SW_SHOWNORMAL;
+      break;
     default:
       native_show_state = delegate_->GetInitialShowState();
       break;
   }
 
   ShowWindow(hwnd(), native_show_state);
   // When launched from certain programs like bash and Windows Live Messenger,
   // show_state is set to SW_HIDE, so we need to correct that condition. We
   // don't just change show_state to SW_SHOWNORMAL because MSDN says we must
   // always first call ShowWindow with the specified value from STARTUPINFO,
@@ skipping 15 matching lines @@
   if (!delegate_->HandleInitialFocus(show_state))
     SetInitialFocus();
 }
 
 void HWNDMessageHandler::ShowMaximizedWithBounds(const gfx::Rect& bounds) {
   WINDOWPLACEMENT placement = { 0 };
   placement.length = sizeof(WINDOWPLACEMENT);
   placement.showCmd = SW_SHOWMAXIMIZED;
   placement.rcNormalPosition = bounds.ToRECT();
   SetWindowPlacement(hwnd(), &placement);
+
+  // We need to explicitly activate the window, because if we're opened from a
+  // desktop shortcut while an existing window is already running it doesn't
+  // seem to be enough to use SW_SHOWMAXIMIZED to activate the window.
+  Activate();

[sky, 2014/11/24 16:23:07]

I think you're working around a problem that may be else where in the code.
Does this also happen when showing non-maximized?

If Chrome is already running and you click a shortcut then I believe we end up
passing a message to chrome. Do we need to do something else to ensure the
existing chrome ends up as the active/focused app?

[Tomasz Moniuszko, 2014/11/27 15:35:50]

No it doesn't because Activate() is being called from
HWNDMessageHandler::ShowWindowWithState(). It does when I remove Activate() call
from that method.

If new window is opened from jumplist while existing window is maximized,
HWNDMessageHandler::ShowMaximizedWithBounds() is called instead of
ShowWindowWithState() so calling Activate() from here is just analogous
solution.

[sky, 2014/12/01 17:11:45]

Ah, ok, I get it.
I don't think you need the comment here. We should activate just as we do in the

 }
 
 void HWNDMessageHandler::Hide() {
   if (IsWindow(hwnd())) {
     // NOTE: Be careful not to activate any windows here (for example, calling
     // ShowWindow(SW_HIDE) will automatically activate another window).  This
     // code can be called while a window is being deactivated, and activating
     // another window will screw up the activation that is already in progress.
     SetWindowPos(hwnd(), NULL, 0, 0, 0, 0,
                  SWP_HIDEWINDOW | SWP_NOACTIVATE | SWP_NOMOVE |
@@ skipping 1852 matching lines @@
     SetWindowPos(hwnd(), NULL, 0, 0, 0, 0, flags | SWP_HIDEWINDOW);
     SetWindowPos(hwnd(), NULL, 0, 0, 0, 0, flags | SWP_SHOWWINDOW);
   }
   // WM_DWMCOMPOSITIONCHANGED is only sent to top level windows, however we want
   // to notify our children too, since we can have MDI child windows who need to
   // update their appearance.
   EnumChildWindows(hwnd(), &SendDwmCompositionChanged, NULL);
 }
 
 }  // namespace views