Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 725913003: Fix stroke color definition of canvas context. (Closed)

Created:
6 years, 1 month ago by reni
Modified:
6 years, 1 month ago
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix stroke color definition of canvas context. The stroke's color of a canvas can be given with the combination of a CSS color and an optional alpha value. The color part can be defined with both basic or extended color keywords. Using a basic keyword with an alpha value works fine but it does not work with extended colors. The reason is that blink::CanvasStyle::createFromStringWithOverrideAlpha is not prepared for getting a system color. This is basically due to a missing case branch. The patch supplies this missing branch. R=rob.buis@samsung.org,schenney@chromium.org BUG=434812 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185656

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typos in the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/canvas/stroke-with-system-color-and-alpha-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reni
6 years, 1 month ago (2014-11-19 20:06:08 UTC) #1
Stephen Chennney
+junov, +senorblanco
6 years, 1 month ago (2014-11-19 20:11:12 UTC) #3
Justin Novosad
On 2014/11/19 20:11:12, Stephen Chenney wrote: > +junov, +senorblanco lgtm
6 years, 1 month ago (2014-11-19 20:21:22 UTC) #4
Stephen White
LGTM w/nits https://codereview.chromium.org/725913003/diff/1/LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html File LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html (right): https://codereview.chromium.org/725913003/diff/1/LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html#newcode3 LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html:3: <p>PASS if Blink does not crashes in ...
6 years, 1 month ago (2014-11-19 21:10:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725913003/20001
6 years, 1 month ago (2014-11-20 09:37:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=185656
6 years, 1 month ago (2014-11-20 10:21:42 UTC) #8
reni
6 years, 1 month ago (2014-11-20 10:38:15 UTC) #9
Message was sent while issue was closed.
Thanks for the reviews!

Powered by Google App Engine
This is Rietveld 408576698