Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 725903002: Timeline: move preview up, pie chart down in Details (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 501
502 var recordTypes = WebInspector.TimelineModel.RecordType; 502 var recordTypes = WebInspector.TimelineModel.RecordType;
503 503
504 // This message may vary per event.name; 504 // This message may vary per event.name;
505 var relatedNodeLabel; 505 var relatedNodeLabel;
506 506
507 var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.targ et(), linkifier, true); 507 var contentHelper = new WebInspector.TimelineDetailsContentHelper(model.targ et(), linkifier, true);
508 contentHelper.appendTextRow(WebInspector.UIString("Type"), WebInspector.Time lineUIUtils.eventTitle(event, model)); 508 contentHelper.appendTextRow(WebInspector.UIString("Type"), WebInspector.Time lineUIUtils.eventTitle(event, model));
509 contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.milli sToString(event.selfTime, true)); 509 contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.milli sToString(event.selfTime, true));
510 contentHelper.appendTextRow(WebInspector.UIString("Start Time"), Number.mill isToString((event.startTime - model.minimumRecordTime()))); 510 contentHelper.appendTextRow(WebInspector.UIString("Start Time"), Number.mill isToString((event.startTime - model.minimumRecordTime())));
511 contentHelper.appendElementRow(WebInspector.UIString("Aggregated Time"), pie Chart); 511 if (event.previewElement)
512 contentHelper.appendElementRow(WebInspector.UIString("Preview"), event.p reviewElement);
513
512 var eventData = event.args["data"]; 514 var eventData = event.args["data"];
513 var initiator = event.initiator; 515 var initiator = event.initiator;
514 516
515 switch (event.name) { 517 switch (event.name) {
516 case recordTypes.GCEvent: 518 case recordTypes.GCEvent:
517 var delta = event.args["usedHeapSizeBefore"] - event.args["usedHeapSizeA fter"]; 519 var delta = event.args["usedHeapSizeBefore"] - event.args["usedHeapSizeA fter"];
518 contentHelper.appendTextRow(WebInspector.UIString("Collected"), Number.b ytesToString(delta)); 520 contentHelper.appendTextRow(WebInspector.UIString("Collected"), Number.b ytesToString(delta));
519 break; 521 break;
520 case recordTypes.TimerFire: 522 case recordTypes.TimerFire:
521 case recordTypes.TimerInstall: 523 case recordTypes.TimerInstall:
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 624
623 if (eventData && eventData["scriptName"] && event.name !== recordTypes.Funct ionCall) 625 if (eventData && eventData["scriptName"] && event.name !== recordTypes.Funct ionCall)
624 contentHelper.appendLocationRow(WebInspector.UIString("Function Call"), eventData["scriptName"], eventData["scriptLine"]); 626 contentHelper.appendLocationRow(WebInspector.UIString("Function Call"), eventData["scriptName"], eventData["scriptLine"]);
625 627
626 var warning = event.warning; 628 var warning = event.warning;
627 if (warning) { 629 if (warning) {
628 var div = createElement("div"); 630 var div = createElement("div");
629 div.textContent = warning; 631 div.textContent = warning;
630 contentHelper.appendElementRow(WebInspector.UIString("Warning"), div); 632 contentHelper.appendElementRow(WebInspector.UIString("Warning"), div);
631 } 633 }
632 if (event.previewElement) 634
633 contentHelper.appendElementRow(WebInspector.UIString("Preview"), event.p reviewElement); 635 contentHelper.appendElementRow(WebInspector.UIString("Aggregated Time"), pie Chart);
634 636
635 if (event.stackTrace || (event.initiator && event.initiator.stackTrace) || e vent.invalidationTrackingEvents) 637 if (event.stackTrace || (event.initiator && event.initiator.stackTrace) || e vent.invalidationTrackingEvents)
636 WebInspector.TimelineUIUtils._generateCauses(event, model.target(), cont entHelper); 638 WebInspector.TimelineUIUtils._generateCauses(event, model.target(), cont entHelper);
637 639
638 fragment.appendChild(contentHelper.element); 640 fragment.appendChild(contentHelper.element);
639 641
640 return fragment; 642 return fragment;
641 } 643 }
642 644
643 /** 645 /**
(...skipping 696 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 for (var i = 0; i < stackTrace.length; ++i) { 1342 for (var i = 0; i < stackTrace.length; ++i) {
1341 var stackFrame = stackTrace[i]; 1343 var stackFrame = stackTrace[i];
1342 var row = stackTraceElement.createChild("div"); 1344 var row = stackTraceElement.createChild("div");
1343 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)")); 1345 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)"));
1344 row.createTextChild(" @ "); 1346 row.createTextChild(" @ ");
1345 var urlElement = this._linkifier.linkifyScriptLocation(this._target, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame.colu mnNumber - 1); 1347 var urlElement = this._linkifier.linkifyScriptLocation(this._target, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame.colu mnNumber - 1);
1346 row.appendChild(urlElement); 1348 row.appendChild(urlElement);
1347 } 1349 }
1348 } 1350 }
1349 } 1351 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698