Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4527)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 725853002: Move app launch metric recording code from NTP to chrome/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More mac Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_metrics.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index e8bc6a0aaa60022d08f856faf54b27a09155b872..5b427d532d221693fecdf77d6c4aafda5f62f79b 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -18,7 +18,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/crash_keys.h"
-#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_metrics.h"
#include "chrome/common/localized_error.h"
#include "chrome/common/pepper_permission_util.h"
#include "chrome/common/render_messages.h"
@@ -1272,12 +1272,8 @@ bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
const Extension* extension =
extension_dispatcher_->extensions()->GetExtensionOrAppByURL(url);
if (extension && extension->is_app()) {
- UMA_HISTOGRAM_ENUMERATION(
- extension->is_platform_app() ?
- extension_misc::kPlatformAppLaunchHistogram :
- extension_misc::kAppLaunchHistogram,
- extension_misc::APP_LAUNCH_CONTENT_NAVIGATION,
- extension_misc::APP_LAUNCH_BUCKET_BOUNDARY);
+ extensions::RecordAppLaunchType(
+ extension_misc::APP_LAUNCH_CONTENT_NAVIGATION, extension->GetType());
}
return true;
}
« no previous file with comments | « chrome/common/extensions/extension_metrics.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698