Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 72583002: Remove TreatNullAs=NullString for HTMLEmbedElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLEmbedElement http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#htmlembedelement http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#HTMLEmbedElement-partial The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE11 reflects align/type as null, and width/height as the empty string. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-14 09:30:17 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-14 11:50:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/72583002/1
7 years, 1 month ago (2013-11-14 11:54:41 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 12:52:53 UTC) #4
Message was sent while issue was closed.
Change committed as 162013

Powered by Google App Engine
This is Rietveld 408576698