Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7258007: Move the tts and ttsEngine APIs out of experimental, and give (Closed)

Created:
9 years, 5 months ago by dmazzoni
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move the tts and ttsEngine APIs out of experimental, and give them new explicit permissions and install warning messages. Also change the hidden event ttsEngine.onEvent to tts.onEvent, which is where it belongs because it's sent to clients who call tts.speak and has nothing to do with engines. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93232

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 7

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4546 lines, -4940 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tts_api.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tts_api_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_engine_api.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_engine_api.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/access_chromevox/manifest.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 3 4 3 chunks +17 lines, -15 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/experimental.tts.html View 1 2 3 4 5 1 chunk +0 lines, -2949 lines 0 comments Download
D chrome/common/extensions/docs/experimental.ttsEngine.html View 1 2 3 4 5 1 chunk +0 lines, -1475 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 4 6 chunks +13 lines, -17 lines 0 comments Download
D chrome/common/extensions/docs/static/experimental.tts.html View 1 2 3 4 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/common/extensions/docs/static/experimental.ttsEngine.html View 1 2 3 4 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/common/extensions/docs/static/tts.html View 1 2 3 8 chunks +15 lines, -14 lines 0 comments Download
A + chrome/common/extensions/docs/static/ttsEngine.html View 1 2 3 5 chunks +10 lines, -12 lines 0 comments Download
A chrome/common/extensions/docs/tts.html View 1 2 3 5 1 chunk +2950 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/ttsEngine.html View 1 2 3 5 1 chunk +1424 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 2 3 4 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/renderer/resources/renderer_extension_bindings.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/chromeos/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/chromeos/test.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/enqueue/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/enqueue/test.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/interrupt/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/interrupt/test.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/optional_args/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/optional_args/test.js View 1 2 3 4 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/queue_interrupt/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/queue_interrupt/test.js View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/speak_error/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/speak_error/test.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/speak_once/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/speak_once/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tts/word_callbacks/manifest.json View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts/word_callbacks/test.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/engine_error/manifest.json View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/engine_error/test.js View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/engine_word_callbacks/manifest.json View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/engine_word_callbacks/test.js View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/register_engine/manifest.json View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/tts_engine/register_engine/test.js View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
9 years, 5 months ago (2011-07-15 17:00:21 UTC) #1
Erik does not do reviews
Not a thorough review (so I'll defer to Ben for the other details), but overall ...
9 years, 5 months ago (2011-07-15 23:04:04 UTC) #2
Ben Olmstead
LGTM, minus the dead code in build.py and (per Erik's comments) the TTS API warning. ...
9 years, 5 months ago (2011-07-19 23:28:30 UTC) #3
Ben Olmstead
LGTM, minus the dead code in build.py and (per Erik's comments) the TTS API warning. ...
9 years, 5 months ago (2011-07-19 23:28:30 UTC) #4
dmazzoni
Thanks again to both of you for your responsiveness, I'm really happy to be able ...
9 years, 5 months ago (2011-07-20 05:58:04 UTC) #5
commit-bot: I haz the power
9 years, 5 months ago (2011-07-20 19:25:12 UTC) #6 
Can't process patch for file chrome/common/extensions/docs/static/tts.html.
A  +

Powered by Google App Engine
This is Rietveld 408576698