Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 725773002: Revert of Roll Clang 218707:220284 (+cherry-picks of 220340, 220403 and 220407) (Closed)

Created:
6 years, 1 month ago by DaleCurtis
Modified:
6 years, 1 month ago
Reviewers:
hans, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Clang 218707:220284 (+cherry-picks of 220340, 220403 and 220407) (patchset #4 id:60001 of https://codereview.chromium.org/718513002/) Reason for revert: Sizes regression, http://crbug.com/433067 Original issue's description: > Roll Clang 218707:220284 (+cherry-picks of 220340, 220403 and 220407) > > Also: > - Update the build script to work with the new Android NDK > - Make the package script fail if the update script fails. > > BUG=431803 > R=thakis@chromium.org > > Committed: https://crrev.com/18dd7aa2a0a236c14fb6889d526d3fe6e1dfa08c > Cr-Commit-Position: refs/heads/master@{#304081} TBR=thakis@chromium.org,hans@chromium.org NOTREECHECKS=true NOTRY=true BUG=431803 Committed: https://crrev.com/32a7c255702e76d59d675875c2ce14e47259300b Cr-Commit-Position: refs/heads/master@{#304109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -415 lines) Patch
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/package.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 4 chunks +162 lines, -413 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of Roll Clang 218707:220284 (+cherry-picks of 220340, 220403 and 220407)
6 years, 1 month ago (2014-11-13 23:14:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725773002/1
6 years, 1 month ago (2014-11-13 23:16:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 23:19:15 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:36:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32a7c255702e76d59d675875c2ce14e47259300b
Cr-Commit-Position: refs/heads/master@{#304109}

Powered by Google App Engine
This is Rietveld 408576698