[Cronet] Initial implementation of HttpURLConnection

components/cronet/android/java/src/org/chromium/net/urlconnection/ByteBufferInputStream.java

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net.urlconnection;
+
+import java.io.InputStream;
+import java.nio.ByteBuffer;
+
+/**
+ * Wrapper class to construct an InputSteam based on a ByteBuffer.
+ */
+class ByteBufferInputStream extends InputStream {

[mmenke, 2014/11/20 18:52:36]

Suggest a more specific name, since this isn't really a general InputStream that
uses a ByteBuffer.  Maybe just CronetInputStream or
Cronet[Http]URLConnectionInputStream, if we really want to be complete.

[xunjieli, 2014/11/20 20:31:59]

Done.

+    private final MessageLoop mMessageLoop;
+    // Indicates whether listener's onSucceeded or onFailed callback is invoked.
+    private boolean mResponseDataCompleted;
+    private ByteBuffer mBuffer;
+
+    public ByteBufferInputStream(MessageLoop messageLoop) {
+        mMessageLoop = messageLoop;
+    }
+
+    @Override
+    public int read() {
+        if (mBuffer == null
+                || (!mBuffer.hasRemaining() && !mResponseDataCompleted)) {
+            mMessageLoop.loop();

[mmenke, 2014/11/20 18:52:36]

Rather than using the message loop directly, I think it makes more sense to call
into a private method in CronetHttpURLConnection to request more data.

[xunjieli, 2014/11/20 20:31:59]

Done.

+        }
+        if (mBuffer.hasRemaining()) {
+            return mBuffer.get() & 0xFF;
+        }
+        return -1;

[mmenke, 2014/11/20 18:52:36]

If there was a failure rather than a successful completion, should we be
throwing an exception?  I guess you have TODOs about this elsewhere.

[xunjieli, 2014/11/20 20:31:59]

Acknowledged. Right, I think I will handle failure in a follow-up CL.

+    }
+
+    public void setResponseDataCompleted() {
+        mResponseDataCompleted = true;
+    }
+
+    public void setByteBuffer(ByteBuffer buffer) {
+        mBuffer = buffer;
+    }
+}