Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 725633002: Revert "TransitionArray::Search() now returns insertion index if the entry was not found." (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert "TransitionArray::Search() now returns insertion index if the entry was not found." This reverts the commit because it possibly causes renderer hangs. BUG=chromium:431807 LOG=N R=verwaest@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/994094cc62ab403ba55704c810903ecf5f2627a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -75 lines) Patch
M src/objects.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/objects-inl.h View 5 chunks +13 lines, -34 lines 0 comments Download
M src/transitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/transitions.cc View 4 chunks +30 lines, -32 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-13 15:37:45 UTC) #2
Toon Verwaest
(rubberstamp) lgtm
6 years, 1 month ago (2014-11-13 16:57:57 UTC) #3
Igor Sheludko
6 years, 1 month ago (2014-11-13 16:59:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
994094cc62ab403ba55704c810903ecf5f2627a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698