Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 7256003: Bypass proxy for local addresses on chromeOS. (Closed)

Created:
9 years, 6 months ago by Denis Lagno
Modified:
9 years, 5 months ago
Reviewers:
kuan
CC:
chromium-reviews, davemoore+watch_chromium.org, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

Bypass proxy for local addresses on chromeOS. It is needed for current implementation of websocket-to-tcp proxy (that listens loopback interface). BUG=chromium-os:16104 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90783

Patch Set 1 : avoid direct rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/chromeos/proxy_config_service_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Denis Lagno
please take a look
9 years, 6 months ago (2011-06-24 18:55:14 UTC) #1
Denis Lagno
ping
9 years, 5 months ago (2011-06-28 10:59:33 UTC) #2
kuan
9 years, 5 months ago (2011-06-28 14:29:21 UTC) #3
lgtm.
i apologize for delay.

Powered by Google App Engine
This is Rietveld 408576698