Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 725593006: Implementation of TestRunner::Sleep (Closed)

Created:
6 years, 1 month ago by João Eiras
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implementation of TestRunner::Sleep Which blocks script execution and loading for the caller for a given amount of time, like an alert() call. BUG=418116

Patch Set 1 #

Patch Set 2 : long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 5 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
João Eiras
This API is here to help with testing https://codereview.chromium.org/625583002/ I'd like to know your opinion ...
6 years, 1 month ago (2014-11-18 15:14:09 UTC) #2
Ken Russell (switch to Gerrit)
+more test_runner OWNERS This seems basically OK though I would try to find a more ...
6 years, 1 month ago (2014-11-18 21:44:20 UTC) #4
tkent
We shouldn't add this. A test with this would be flaky. If a test has ...
6 years, 1 month ago (2014-11-19 01:16:21 UTC) #5
João Eiras
On 2014/11/19 01:16:21, tkent wrote: > We shouldn't add this. > A test with this ...
6 years, 1 month ago (2014-11-19 02:39:43 UTC) #6
tkent
6 years, 1 month ago (2014-11-19 03:47:33 UTC) #7
On 2014/11/19 02:39:43, João Eiras wrote:
> Eric asked for a test for https://codereview.chromium.org/625583002/
> How do you suggest the defers loading flag to be set and the message queue ran
> to verify that the asserts don't trigger ?
> The timeout is there so the testcase is not stuck indefinitely. The API is
> supposed to behave similar to having an alert() open for a while.

Though I don't understand the detail of what you need, we should add a
testRunner function to cause the state change immediately.

Powered by Google App Engine
This is Rietveld 408576698