Prevent the load event from firing inside DOMContentLoaded

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 445 matching lines @@
     , m_compatibilityModeLocked(false)
     , m_executeScriptsWaitingForResourcesTimer(this, &Document::executeScriptsWaitingForResourcesTimerFired)
     , m_hasAutofocused(false)
     , m_clearFocusedElementTimer(this, &Document::clearFocusedElementTimerFired)
     , m_domTreeVersion(++s_globalTreeVersion)
     , m_listenerTypes(0)
     , m_mutationObserverTypes(0)
     , m_visitedLinkState(VisitedLinkState::create(*this))
     , m_visuallyOrdered(false)
     , m_readyState(Complete)
-    , m_isParsing(false)
+    , m_parsingState(Done)
     , m_gotoAnchorNeededAfterStylesheetsLoad(false)
     , m_containsValidityStyleRules(false)
     , m_updateFocusAppearanceRestoresSelection(false)
     , m_containsPlugins(false)
     , m_ignoreDestructiveWriteCount(0)
     , m_markers(adoptPtrWillBeNoop(new DocumentMarkerController))
     , m_updateFocusAppearanceTimer(this, &Document::updateFocusAppearanceTimerFired)
     , m_cssTarget(nullptr)
     , m_loadEventProgress(LoadEventNotRun)
     , m_startTime(currentTime())
@@ skipping 1892 matching lines @@
 PassRefPtrWillBeRawPtr<DocumentParser> Document::implicitOpen()
 {
     cancelParsing();
 
     removeChildren();
     ASSERT(!m_focusedElement);
 
     setCompatibilityMode(NoQuirksMode);
 
     m_parser = createParser();
-    setParsing(true);
+    setParsingState(Parsing);
     setReadyState(Loading);
 
     return m_parser;
 }
 
 HTMLElement* Document::body() const
 {
     if (!documentElement())
         return 0;
 
@@ skipping 273 matching lines @@
 {
     if (m_loadEventProgress == BeforeUnloadEventInProgress)
         return BeforeUnloadDismissal;
     if (m_loadEventProgress == PageHideInProgress)
         return PageHideDismissal;
     if (m_loadEventProgress == UnloadEventInProgress)
         return UnloadDismissal;
     return NoDismissal;
 }
 
-void Document::setParsing(bool b)
+void Document::setParsingState(ParsingState parsingState)
 {
-    m_isParsing = b;
+    m_parsingState = parsingState;
 
-    if (m_isParsing && !m_elementDataCache)
+    if (m_parsingState == Parsing && !m_elementDataCache)

[sof, 2014/11/14 21:34:02]

Use parsing() instead?

[Nate Chapin, 2014/11/14 22:05:24]

Done.

         m_elementDataCache = ElementDataCache::create();
 }
 
 bool Document::shouldScheduleLayout() const
 {
     // This function will only be called when FrameView thinks a layout is needed.
     // This enforces a couple extra rules.
     //
     //    (a) Only schedule a layout once the stylesheets are loaded.
     //    (b) Only schedule layout once we have a body element.
@@ skipping 1735 matching lines @@
 
 void Document::applyXSLTransform(ProcessingInstruction* pi)
 {
     ASSERT(!pi->isLoading());
     UseCounter::count(*this, UseCounter::XSLProcessingInstruction);
     RefPtrWillBeRawPtr<XSLTProcessor> processor = XSLTProcessor::create(*this);
     processor->setXSLStyleSheet(toXSLStyleSheet(pi->sheet()));
     String resultMIMEType;
     String newSource;
     String resultEncoding;
-    setParsing(true);
+    setParsingState(Parsing);
     if (!processor->transformToString(this, resultMIMEType, newSource, resultEncoding)) {
-        setParsing(false);
+        setParsingState(Done);
         return;
     }
     // FIXME: If the transform failed we should probably report an error (like Mozilla does).
     LocalFrame* ownerFrame = frame();
     processor->createDocumentFromSource(newSource, resultEncoding, resultMIMEType, this, ownerFrame);
     InspectorInstrumentation::frameDocumentUpdated(ownerFrame);
-    setParsing(false);
+    setParsingState(Done);
 }
 
 void Document::setTransformSource(PassOwnPtr<TransformSource> source)
 {
     m_transformSource = source;
 }
 
 void Document::setDesignMode(InheritedBool value)
 {
     m_designMode = value;
@@ skipping 164 matching lines @@
 
 PassRefPtrWillBeRawPtr<DocumentNameCollection> Document::documentNamedItems(const AtomicString& name)
 {
     return ensureCachedCollection<DocumentNameCollection>(DocumentNamedItems, name);
 }
 
 void Document::finishedParsing()
 {
     ASSERT(!scriptableDocumentParser() || !m_parser->isParsing());
     ASSERT(!scriptableDocumentParser() || m_readyState != Loading);
-    setParsing(false);
+    setParsingState(InDOMContentLoaded);
     if (!m_documentTiming.domContentLoadedEventStart)
         m_documentTiming.domContentLoadedEventStart = monotonicallyIncreasingTime();
     dispatchEvent(Event::createBubble(EventTypeNames::DOMContentLoaded));
     if (!m_documentTiming.domContentLoadedEventEnd)
         m_documentTiming.domContentLoadedEventEnd = monotonicallyIncreasingTime();
+    setParsingState(Done);
 
     // The loader's finishedParsing() method may invoke script that causes this object to
     // be dereferenced (when this document is in an iframe and the onload causes the iframe's src to change).
     // Keep it alive until we are done.
     RefPtrWillBeRawPtr<Document> protect(this);
 
     if (RefPtrWillBeRawPtr<LocalFrame> frame = this->frame()) {
         // Don't update the render tree if we haven't requested the main resource yet to avoid
         // adding extra latency. Note that the first render tree update can be expensive since it
         // triggers the parsing of the default stylesheets which are compiled-in.
@@ skipping 1205 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif