LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt - Issue 725593004: Prevent the load event from firing inside DOMContentLoaded

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt

Issue 725593004: Prevent the load event from firing inside DOMContentLoaded (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 CONSOLE ERROR: line 34: Uncaught InvalidStateError: Failed to execute 'send' on 'XMLHttpRequest': The object's state must be OPENED.
Nate Chapin 2014/11/14 00:32:35 The code changes in this CL may have neutered this The code changes in this CL may have neutered this test, I'm not certain. sof 2014/11/14 21:34:02 Could you investigate a bit further? i.e., should Show quoted text On 2014/11/14 00:32:35, Nate Chapin wrote: > The code changes in this CL may have neutered this test, I'm not certain. Could you investigate a bit further? i.e., should all occurrences of !parsing() also encompass the InDocumentLoaded state - is that preventing the delivery of DOMSubtreeModified? Nate Chapin 2014/11/14 22:05:24 DOMSubtreeModified is firing the same number of ti Show quoted text On 2014/11/14 21:34:02, sof wrote: > On 2014/11/14 00:32:35, Nate Chapin wrote: > > The code changes in this CL may have neutered this test, I'm not certain. > > Could you investigate a bit further? i.e., should all occurrences of !parsing() > also encompass the InDocumentLoaded state - is that preventing the delivery of > DOMSubtreeModified? DOMSubtreeModified is firing the same number of times, but this test appears to depend on those firing reentrantly because the load event is firing inside of DOMContentLoaded. I'm not sure how to recreate that. sof 2014/11/14 22:16:07 ok, that no DOMSubtreeModifieds were being muted w Show quoted text On 2014/11/14 22:05:24, Nate Chapin wrote: > On 2014/11/14 21:34:02, sof wrote: > > On 2014/11/14 00:32:35, Nate Chapin wrote: > > > The code changes in this CL may have neutered this test, I'm not certain. > > > > Could you investigate a bit further? i.e., should all occurrences of > !parsing() > > also encompass the InDocumentLoaded state - is that preventing the delivery of > > DOMSubtreeModified? > > DOMSubtreeModified is firing the same number of times, but this test appears to > depend on those firing reentrantly because the load event is firing inside of > DOMContentLoaded. I'm not sure how to recreate that. ok, that no DOMSubtreeModifieds were being muted was main concern. tyoshino (Cc:ed) may have some ideas on how to rephrase the test, but fine with me to move ahead.
2 insertedText	1 insertedText

3 This tests that when we re-entrantly create and cancel XHRs, we don't try to dis connect the same CachedResourceClient multiple times from its CachedResource. We pass if we don't crash.	2 This tests that when we re-entrantly create and cancel XHRs, we don't try to dis connect the same CachedResourceClient multiple times from its CachedResource. We pass if we don't crash.

4 DOMContentLoadedload	3 DOMContentLoaded

	4 load

5	5

6

OLD	NEW

« no previous file with comments | « LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt ('k') | Source/core/dom/Document.h » ('j') | Source/core/dom/Document.h » ('J')