Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 725593002: Install the constructor property on custom prototype before optimizing it as a prototype (Closed)

Created:
6 years, 1 month ago by Toon Verwaest
Modified:
6 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Install the constructor property on custom prototype before optimizing it as a prototype BUG= R=ishell@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c8e5a1add7b0b3184db92135a0b8ace065ecc24d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/factory.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/factory.cc View 4 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
PTAL
6 years, 1 month ago (2014-11-13 14:02:06 UTC) #2
Igor Sheludko
lgtm
6 years, 1 month ago (2014-11-13 14:09:13 UTC) #3
Toon Verwaest
6 years, 1 month ago (2014-11-13 14:13:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8e5a1add7b0b3184db92135a0b8ace065ecc24d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698