Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 725583003: [DevTools] Prepare to pass modified InspectorFrontendHost to inspector app. (Closed)

Created:
6 years, 1 month ago by dgozman
Modified:
6 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Prepare to pass modified InspectorFrontendHost to inspector app. BUG=431697 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185317

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -104 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/devtools_app/DevToolsApp.js View 1 1 chunk +6 lines, -33 lines 0 comments Download
A Source/devtools/front_end/devtools_app/UITests.js View 1 chunk +25 lines, -0 lines 0 comments Download
M Source/devtools/front_end/devtools_app/module.json View 1 chunk +4 lines, -0 lines 0 comments Download
D Source/devtools/front_end/host/InspectorAppHost.js View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/host/module.json View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/main/Tests.js View 6 chunks +17 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
6 years, 1 month ago (2014-11-13 15:58:49 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/725583003/diff/1/Source/devtools/front_end/devtools_app/DevToolsApp.js File Source/devtools/front_end/devtools_app/DevToolsApp.js (right): https://codereview.chromium.org/725583003/diff/1/Source/devtools/front_end/devtools_app/DevToolsApp.js#newcode16 Source/devtools/front_end/devtools_app/DevToolsApp.js:16: this._iframe = document.querySelector("iframe.inspector-app-iframe"); just inline onIframeLoaded here.
6 years, 1 month ago (2014-11-13 17:48:11 UTC) #3
dgozman
https://codereview.chromium.org/725583003/diff/1/Source/devtools/front_end/devtools_app/DevToolsApp.js File Source/devtools/front_end/devtools_app/DevToolsApp.js (right): https://codereview.chromium.org/725583003/diff/1/Source/devtools/front_end/devtools_app/DevToolsApp.js#newcode16 Source/devtools/front_end/devtools_app/DevToolsApp.js:16: this._iframe = document.querySelector("iframe.inspector-app-iframe"); On 2014/11/13 17:48:11, pfeldman wrote: > ...
6 years, 1 month ago (2014-11-13 17:53:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725583003/20001
6 years, 1 month ago (2014-11-13 17:53:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 20:23:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185317

Powered by Google App Engine
This is Rietveld 408576698