Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 725573004: Do not AppCache responses with SSL cert errors unless running with the --ignore-certificate-errors … (Closed)

Created:
5 years, 1 month ago by michaeln
Modified:
5 years, 1 month ago
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not AppCache responses with SSL cert errors unless running with the --ignore-certificate-errors flag. BUG=414026 Committed: https://crrev.com/c65cc9c7b1afe7f53bb18707bc711dc32ddffad0 Cr-Commit-Position: refs/heads/master@{#304140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/appcache/appcache_update_job.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
michaeln
ptal
5 years, 1 month ago (2014-11-13 22:50:56 UTC) #2
Ryan Sleevi
rvargas as FYI. As mentioned, we don't cache HTTP responses with cert errors (which --ignore-certificate-errors ...
5 years, 1 month ago (2014-11-13 23:04:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725573004/1
5 years, 1 month ago (2014-11-14 00:32:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2014-11-14 01:40:46 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2014-11-14 01:41:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c65cc9c7b1afe7f53bb18707bc711dc32ddffad0
Cr-Commit-Position: refs/heads/master@{#304140}

Powered by Google App Engine
This is Rietveld 408576698