Do not AppCache responses with SSL cert errors unless running with the --ignore-certificate-errors …

Do not AppCache responses with SSL cert errors unless running with the --ignore-certificate-errors flag.

BUG=414026
Committed: https://crrev.com/c65cc9c7b1afe7f53bb18707bc711dc32ddffad0
Cr-Commit-Position: refs/heads/master@{#304140}

[michaeln, 2014-11-13 22:50:45]

michaeln@chromium.org changed reviewers:
+ rsleevi@chromium.org

[michaeln, 2014-11-13 22:50:56]

ptal

[Ryan Sleevi, 2014-11-13 23:04:27]

rsleevi@chromium.org changed reviewers:
+ rvargas@chromium.org

[Ryan Sleevi, 2014-11-13 23:04:28]

rvargas as FYI.

As mentioned, we don't cache HTTP responses with cert errors (which
--ignore-certificate-errors always is), which is
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_cach...

This effectively causes AppCache to behave differently than the HTTP cache in
this case. However, I _think_ that's OK (as I mentioned via email), as it's a
temporary solution until I can nuke the --ignore-certificate-errors flag (which
applies to ERRYTHANG) and make it a scoped-for-host-and-cert flag (as discussed
on net-dev).

I'll let Ricardo yell if he's bothered too fundamentally by the inconsistency,
but otherwise LGTM (and as a merge target) as a temporary solution.

I'm having trouble with crbug at the moment, but I'd like to make sure we attach
a bug to nuke it with something like

TODO(rsleevi): AppCache should match the HTTP cache. http://crbug.com/FOO

with FOO being a bug assigned to me to remove --ignore-certificate-errors

[michaeln, 2014-11-14 00:30:16]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-11-14 00:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/725573004/1

[commit-bot: I haz the power, 2014-11-14 01:40:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-14 01:41:59]

Patchset 1 (id:??) landed as
https://crrev.com/c65cc9c7b1afe7f53bb18707bc711dc32ddffad0
Cr-Commit-Position: refs/heads/master@{#304140}