Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 725553002: Revert of Migrate device utils WriteFile to AdbWrapper (Closed)

Created:
6 years, 1 month ago by Sami
Modified:
6 years, 1 month ago
Reviewers:
perezju, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate device utils WriteFile to AdbWrapper (patchset #5 id:80001 of https://codereview.chromium.org/715853002/) Reason for revert: Looks like this broke most of the perf tests on Nexus 4. Example log: http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1711/steps/rasterize_and_record_micro.polymer/logs/stdio Original issue's description: > Migrate device utils WriteFile to AdbWrapper > > Also merged the functionality of WriteFile and WriteTextFile into a > single method. > > BUG=267773 > > Committed: https://crrev.com/6de48323f78311342108fda8b2f59ba3848eea81 > Cr-Commit-Position: refs/heads/master@{#303902} TBR=jbudorick@chromium.org,perezju@chromium.org NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/1ce3031cf7582e2fbdd2f26f528fa3a9705f5c8b Cr-Commit-Position: refs/heads/master@{#304017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -107 lines) Patch
M build/android/pylib/device/commands/install_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 4 chunks +38 lines, -28 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 4 chunks +129 lines, -75 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sami
Created Revert of Migrate device utils WriteFile to AdbWrapper
6 years, 1 month ago (2014-11-13 12:00:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725553002/1
6 years, 1 month ago (2014-11-13 12:00:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 12:01:08 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 12:01:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ce3031cf7582e2fbdd2f26f528fa3a9705f5c8b
Cr-Commit-Position: refs/heads/master@{#304017}

Powered by Google App Engine
This is Rietveld 408576698