Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 725523002: Do not calculate many sierpinski fractals for each nanobench run unless needed (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org, f(malita)
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Do not calculate many sierpinski fractals for each nanobench run unless needed Removes work done by the constructors of picture_nesting benches, and moves the work to the Benchmark::onPreDraw override. This avoids PictureNesting::sierpinsky showing up in profile traces when profiling other benches. Committed: https://skia.googlesource.com/skia/+/b33402bc877337e576637616b80e13d1546c7ce1

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M bench/PictureNestingBench.cpp View 1 5 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
6 years, 1 month ago (2014-11-13 09:26:32 UTC) #2
mtklein
lgtm, with suggestions. https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp File bench/PictureNestingBench.cpp (right): https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp#newcode28 bench/PictureNestingBench.cpp:28: virtual void onPreDraw() SK_OVERRIDE { Moving ...
6 years, 1 month ago (2014-11-13 16:15:05 UTC) #3
Kimmo Kinnunen
https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp File bench/PictureNestingBench.cpp (right): https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp#newcode28 bench/PictureNestingBench.cpp:28: virtual void onPreDraw() SK_OVERRIDE { On 2014/11/13 16:15:04, mtklein ...
6 years, 1 month ago (2014-11-18 12:42:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725523002/20001
6 years, 1 month ago (2014-11-18 12:42:56 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 12:50:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b33402bc877337e576637616b80e13d1546c7ce1

Powered by Google App Engine
This is Rietveld 408576698