Do not calculate many sierpinski fractals for each nanobench run unless needed

Do not calculate many sierpinski fractals for each nanobench run unless needed

Removes work done by the constructors of picture_nesting benches,
and moves the work to the Benchmark::onPreDraw override.

This avoids PictureNesting::sierpinsky showing up in profile traces
when profiling other benches.

Committed: https://skia.googlesource.com/skia/+/b33402bc877337e576637616b80e13d1546c7ce1

[Kimmo Kinnunen, 2014-11-13 09:26:32]

kkinnunen@nvidia.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-11-13 16:15:05]

lgtm, with suggestions.

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp
File bench/PictureNestingBench.cpp (right):

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cp...
bench/PictureNestingBench.cpp:28: virtual void onPreDraw() SK_OVERRIDE {
Moving this part to onPreDraw() might be overkill.  Those fPaint.set* methods
are trivially cheap.

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cp...
bench/PictureNestingBench.cpp:99: return (pow(3, fMaxPictureLevel) - 1) / 2;
You may need some explicit casts in here.  Our compilers are a little anal about
warning you when you might lose precision.

[Kimmo Kinnunen, 2014-11-18 12:42:20]

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cpp
File bench/PictureNestingBench.cpp (right):

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cp...
bench/PictureNestingBench.cpp:28: virtual void onPreDraw() SK_OVERRIDE {
On 2014/11/13 16:15:04, mtklein wrote:
> Moving this part to onPreDraw() might be overkill.  Those fPaint.set* methods
> are trivially cheap.

Done.

https://codereview.chromium.org/725523002/diff/1/bench/PictureNestingBench.cp...
bench/PictureNestingBench.cpp:99: return (pow(3, fMaxPictureLevel) - 1) / 2;
On 2014/11/13 16:15:04, mtklein wrote:
> You may need some explicit casts in here.  Our compilers are a little anal
about
> warning you when you might lose precision.

Done.

[Kimmo Kinnunen, 2014-11-18 12:42:24]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-11-18 12:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/725523002/20001

[commit-bot: I haz the power, 2014-11-18 12:50:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b33402bc877337e576637616b80e13d1546c7ce1