Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: tools/push-to-trunk/common_includes.py

Issue 725503003: Fix landing candidate pushes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/push-to-trunk/git_recipes.py » ('j') | tools/push-to-trunk/push_to_trunk.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py b/tools/push-to-trunk/common_includes.py
index 21cdcf49777780a7c71d38fc63dd45d533202ee1..ac78ef8d27da7be143dd9ca483ae6e65cb6ab629 100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -287,9 +287,6 @@ class VCInterface(object):
def RemoteBranch(self, name):
raise NotImplementedError()
- def Land(self):
- raise NotImplementedError()
-
def CLLand(self):
raise NotImplementedError()
@@ -356,9 +353,6 @@ class GitInterface(VCInterface):
self.step.Git("tag %s %s" % (tag, commit))
self.step.Git("push origin %s" % tag)
- def Land(self):
- self.step.Git("push origin")
-
def CLLand(self):
self.step.GitCLLand()
« no previous file with comments | « no previous file | tools/push-to-trunk/git_recipes.py » ('j') | tools/push-to-trunk/push_to_trunk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698