Issue 725503003: Fix landing candidate pushes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 725503003: Fix landing candidate pushes. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach

Modified:
6 years, 1 month ago

Reviewers:
tandrii(chromium)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix landing candidate pushes. BUG=chromium:410721 LOG=n TBR=tandrii@chromium.org TEST=script_test.py Committed: https://chromium.googlesource.com/v8/v8/+/6a06348bb7457d4957549a44111de07b2f646446

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -20 lines)			Patch
M	tools/push-to-trunk/common_includes.py	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	tools/push-to-trunk/git_recipes.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	2 chunks	+1 line, -6 lines	1 comment	Download
M	tools/push-to-trunk/test_scripts.py	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

Committed patchset #1 (id:1) manually as 6a06348bb7457d4957549a44111de07b2f646446 (presubmit successful).

6 years, 1 month ago (2014-11-13 09:23:04 UTC) #2

tandrii(chromium)

6 years, 1 month ago (2014-11-13 13:18:50 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/725503003/diff/1/tools/push-to-trunk/push_to_...
File tools/push-to-trunk/push_to_trunk.py (left):

https://codereview.chromium.org/725503003/diff/1/tools/push-to-trunk/push_to_...
tools/push-to-trunk/push_to_trunk.py:57:
"refs/remotes/origin/candidates:refs/pending/heads/candidates")
yeah :(

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages