Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(233)

Issue 7255002: Revert 90373 - Warmth of a connection (cwnd) is estimated by the amount of data written to the so... (Closed)

Created:
9 years, 3 months ago by Dmitry Titov
Modified:
9 years, 3 months ago
Reviewers:
gagansingh
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, jam, PaweĊ‚ Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, brettw-cc_chromium.org, sergeyu+watch_chromium.org, joi+watch-content_chromium.org
Visibility:
Public.

Description

Revert 90373 - Warmth of a connection (cwnd) is estimated by the amount of data written to the socket. Choosing the warmest connection would mean faster resource load times. Caused layout tests http/tests/loading/redirect-methods.html and http/tests/security/xss-DENIED-iframe-src-alias.html fail on deps WebKit bots, and caused http://code.google.com/p/chromium/issues/detail?id=87423 Deps bots failures: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Floading%2Fredirect-methods.html%2Chttp%2Ftests%2Fsecurity%2Fxss-DENIED-iframe-src-alias.html idle time is the time a socket has remained idle (no http requests being served on it). Probability of server resetting a connection increases with idle time duration. Using a cost function that takes into account bytes transferred and idle time to pick best connection to schedule http requests on. CODEREVIEW done in http://codereview.chromium.org/6990036/ Contributed by gagansingh@google.com Review URL: http://codereview.chromium.org/7189055 TBR=gagansingh@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -679 lines) Patch
MM chrome/browser/browser_main.h View 3 chunks +0 lines, -7 lines 0 comments Download
MM chrome/browser/browser_main.cc View 4 chunks +0 lines, -54 lines 0 comments Download
D chrome/browser/browser_main_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
MM chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
MM content/browser/renderer_host/p2p/socket_host_test_utils.h View 2 chunks +0 lines, -10 lines 0 comments Download
MM jingle/glue/pseudotcp_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM jingle/glue/pseudotcp_adapter.cc View 1 chunk +0 lines, -10 lines 0 comments Download
MM jingle/notifier/base/fake_ssl_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM jingle/notifier/base/fake_ssl_client_socket.cc View 2 chunks +1 line, -9 lines 0 comments Download
MM jingle/notifier/base/fake_ssl_client_socket_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
MM jingle/notifier/base/proxy_resolving_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM jingle/notifier/base/proxy_resolving_client_socket.cc View 1 chunk +0 lines, -14 lines 0 comments Download
MM net/curvecp/curvecp_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/curvecp/curvecp_client_socket.cc View 1 chunk +0 lines, -8 lines 0 comments Download
MM net/http/http_basic_stream.h View 2 chunks +0 lines, -6 lines 0 comments Download
MM net/http/http_basic_stream.cc View 5 chunks +0 lines, -46 lines 0 comments Download
MM net/http/http_network_transaction.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM net/http/http_network_transaction_unittest.cc View 2 chunks +0 lines, -29 lines 0 comments Download
MM net/http/http_proxy_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/http/http_proxy_client_socket.cc View 2 chunks +1 line, -17 lines 0 comments Download
MM net/http/http_response_body_drainer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/http/http_stream.h View 1 chunk +0 lines, -4 lines 0 comments Download
MM net/socket/client_socket_pool_base.h View 2 chunks +0 lines, -18 lines 0 comments Download
MM net/socket/client_socket_pool_base.cc View 4 chunks +1 line, -43 lines 0 comments Download
MM net/socket/client_socket_pool_base_unittest.cc View 3 chunks +4 lines, -80 lines 0 comments Download
MM net/socket/socket_test_util.h View 4 chunks +0 lines, -7 lines 0 comments Download
MM net/socket/socket_test_util.cc View 5 chunks +0 lines, -29 lines 0 comments Download
MM net/socket/socks5_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/socks5_client_socket.cc View 2 chunks +1 line, -17 lines 0 comments Download
MM net/socket/socks_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/socks_client_socket.cc View 1 chunk +0 lines, -16 lines 0 comments Download
MM net/socket/ssl_client_socket_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/ssl_client_socket_mac.cc View 1 chunk +0 lines, -16 lines 0 comments Download
MM net/socket/ssl_client_socket_nss.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/ssl_client_socket_nss.cc View 1 chunk +0 lines, -16 lines 0 comments Download
MM net/socket/ssl_client_socket_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/ssl_client_socket_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download
MM net/socket/ssl_server_socket_nss.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/socket/ssl_server_socket_nss.cc View 1 chunk +0 lines, -8 lines 0 comments Download
MM net/socket/ssl_server_socket_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
MM net/socket/stream_socket.h View 2 chunks +0 lines, -7 lines 0 comments Download
MM net/socket/tcp_client_socket_libevent.h View 2 chunks +0 lines, -6 lines 0 comments Download
MM net/socket/tcp_client_socket_libevent.cc View 6 chunks +1 line, -14 lines 0 comments Download
MM net/socket/tcp_client_socket_win.h View 2 chunks +0 lines, -6 lines 0 comments Download
MM net/socket/tcp_client_socket_win.cc View 6 chunks +1 line, -14 lines 0 comments Download
MM net/socket/transport_client_socket_pool_unittest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
MM net/socket/transport_client_socket_unittest.cc View 3 chunks +1 line, -8 lines 0 comments Download
MM net/spdy/spdy_http_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
MM net/spdy/spdy_proxy_client_socket.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Dmitry Titov
9 years, 3 months ago (2011-06-24 18:21:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698