Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: pkg/analyzer/lib/src/generated/parser.dart

Issue 725473005: During resolution, record the target of break/continue statements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/parser.dart
diff --git a/pkg/analyzer/lib/src/generated/parser.dart b/pkg/analyzer/lib/src/generated/parser.dart
index 7bd33af428fde76589e8a979fb219916cf2fada5..77d9328e61e0ac37229b987c0fc830b026794880 100644
--- a/pkg/analyzer/lib/src/generated/parser.dart
+++ b/pkg/analyzer/lib/src/generated/parser.dart
@@ -10751,10 +10751,14 @@ class ResolutionCopier implements AstVisitor<bool> {
@override
bool visitBreakStatement(BreakStatement node) {
BreakStatement toNode = this._toNode as BreakStatement;
- return _and(
+ if (_and(
_isEqualTokens(node.keyword, toNode.keyword),
_isEqualNodes(node.label, toNode.label),
- _isEqualTokens(node.semicolon, toNode.semicolon));
+ _isEqualTokens(node.semicolon, toNode.semicolon))) {
+ // TODO(paulberry): map node.target to toNode.target.
+ return true;
+ }
+ return false;
}
@override
@@ -10916,10 +10920,14 @@ class ResolutionCopier implements AstVisitor<bool> {
@override
bool visitContinueStatement(ContinueStatement node) {
ContinueStatement toNode = this._toNode as ContinueStatement;
- return _and(
+ if (_and(
_isEqualTokens(node.keyword, toNode.keyword),
_isEqualNodes(node.label, toNode.label),
- _isEqualTokens(node.semicolon, toNode.semicolon));
+ _isEqualTokens(node.semicolon, toNode.semicolon))) {
+ // TODO(paulberry): map node.target to toNode.target.
+ return true;
+ }
+ return false;
}
@override

Powered by Google App Engine
This is Rietveld 408576698