Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 725463002: Updates the input_methods.txt file to be consistent with chrome/browser/resources/chromeos/input_me… (Closed)

Created:
6 years, 1 month ago by Shu Chen
Modified:
6 years, 1 month ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, yukishiino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updates the input_methods.txt file to be consistent with chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json. BUG=410979 TEST=None Committed: https://crrev.com/1eb3e255b6f57c6ceb2eec25e1022a322a29e8dd Cr-Commit-Position: refs/heads/master@{#303986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromeos/ime/input_methods.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Shu Chen
Nona, can you please review this cl? Thanks
6 years, 1 month ago (2014-11-13 03:58:14 UTC) #2
Seigo Nonaka
lgtm
6 years, 1 month ago (2014-11-13 03:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725463002/1
6 years, 1 month ago (2014-11-13 03:59:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 04:43:22 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 04:45:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eb3e255b6f57c6ceb2eec25e1022a322a29e8dd
Cr-Commit-Position: refs/heads/master@{#303986}

Powered by Google App Engine
This is Rietveld 408576698