Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 725453002: Fix the paged space statistics report error under debug mode.

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Fix the paged space statistics report error under debug mode. If the code event handler is set (enable vtune jit or gdb jit). GC will be triggered in Logger::LogCodeObjects during Isolate initializaiton. But the property_cell_space_used_ definition in snapshot is 0. This leads to the /0 error if "--heap_stats" flag is enabled. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
chunyang.dai
6 years, 1 month ago (2014-11-13 03:07:16 UTC) #2
hello. Danno.
PTAL.
thanks.

Powered by Google App Engine
This is Rietveld 408576698