base/strings/string_util.h - Issue 725443003: Avoid a string copy in URLRequestResourceBundleJob::GetData().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_util.h

Issue 725443003: Avoid a string copy in URLRequestResourceBundleJob::GetData(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Switch to RefCountedMemory. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/strings/string_util.h

diff --git a/base/strings/string_util.h b/base/strings/string_util.h

index 1e2ac700e1004aae5b5eac736d43ab16e80ef664..5ab2ad5d5477f2a648aa081dda0ad2a5e859754d 100644

--- a/base/strings/string_util.h

+++ b/base/strings/string_util.h

@@ -248,7 +248,7 @@ BASE_EXPORT bool ContainsOnlyChars(const StringPiece16& input,

// IsStringASCII assumes the input is likely all ASCII, and does not leave early

// if it is not the case.

-BASE_EXPORT bool IsStringUTF8(const std::string& str);

+BASE_EXPORT bool IsStringUTF8(const StringPiece& str);

BASE_EXPORT bool IsStringASCII(const StringPiece& str);

BASE_EXPORT bool IsStringASCII(const StringPiece16& str);

// A convenience adaptor for WebStrings, as they don't convert into

« no previous file with comments | « base/i18n/streaming_utf8_validator_perftest.cc ('k') | base/strings/string_util.cc » ('j') | chrome/browser/extensions/chrome_url_request_util.cc » ('J')