Avoid a string copy in URLRequestResourceBundleJob::GetData().

net/url_request/url_request_simple_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_simple_job.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 38 matching lines @@
   DCHECK(bytes_read);
   int remaining = byte_range_.last_byte_position() - data_offset_ + 1;
   if (buf_size > remaining)
     buf_size = remaining;
   memcpy(buf->data(), data_.data() + data_offset_, buf_size);
   data_offset_ += buf_size;
   *bytes_read = buf_size;
   return true;
 }
 
+int URLRequestSimpleJob::GetData(std::string* mime_type,
+                                 std::string* charset,
+                                 std::string* data,
+                                 const CompletionCallback& callback) const {
+  NOTREACHED();
+  return ERR_UNEXPECTED;
+}
+
+int URLRequestSimpleJob::GetStringPieceData(
+    std::string* mime_type,
+    std::string* charset,
+    base::StringPiece* data,
+    const CompletionCallback& callback) {
+  int result = GetData(mime_type, charset, &data_storage_, callback);
+  *data = data_storage_;
+  return result;
+}
+
 void URLRequestSimpleJob::StartAsync() {
   if (!request_)
     return;
 
   if (ranges().size() > 1) {
     // TODO(vadimt): Remove ScopedTracker below once crbug.com/422489 is fixed.
     tracked_objects::ScopedTracker tracking_profile(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(
             "422489 URLRequestSimpleJob::StartAsync 1"));
 
     NotifyDone(URLRequestStatus(URLRequestStatus::FAILED,
                                 ERR_REQUEST_RANGE_NOT_SATISFIABLE));
     return;
   }
 
   if (!ranges().empty() && range_parse_result() == OK)
     byte_range_ = ranges().front();
 
   int result;
   {
     // TODO(vadimt): Remove ScopedTracker below once crbug.com/422489 is fixed.
     // Remove the block and assign 'result' in its declaration.
     tracked_objects::ScopedTracker tracking_profile(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(
             "422489 URLRequestSimpleJob::StartAsync 2"));
 
-    result = GetData(&mime_type_,
-                     &charset_,
-                     &data_,
-                     base::Bind(&URLRequestSimpleJob::OnGetDataCompleted,
-                                weak_factory_.GetWeakPtr()));
+    result =
+        GetStringPieceData(&mime_type_, &charset_, &data_,
+                           base::Bind(&URLRequestSimpleJob::OnGetDataCompleted,
+                                      weak_factory_.GetWeakPtr()));
   }
 
   if (result != ERR_IO_PENDING) {
     // TODO(vadimt): Remove ScopedTracker below once crbug.com/422489 is fixed.
     tracked_objects::ScopedTracker tracking_profile(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(
             "422489 URLRequestSimpleJob::StartAsync 3"));
 
     OnGetDataCompleted(result);
   }
@@ skipping 17 matching lines @@
     int remaining_bytes = byte_range_.last_byte_position() -
         byte_range_.first_byte_position() + 1;
     set_expected_content_size(remaining_bytes);
     NotifyHeadersComplete();
   } else {
     NotifyStartError(URLRequestStatus(URLRequestStatus::FAILED, result));
   }
 }
 
 }  // namespace net