Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2515)

Unified Diff: Source/web/EditorClientImpl.cpp

Issue 72543005: Get rid of explict editor dependency from text field (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: 2013-11-18T17:22:32 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/EditorClientImpl.cpp
diff --git a/Source/web/EditorClientImpl.cpp b/Source/web/EditorClientImpl.cpp
index 897cc044e3e9f74389bb676822ab71e194516d17..834cbf99fd802b3b60478ca1a4d9090aa69b9e12 100644
--- a/Source/web/EditorClientImpl.cpp
+++ b/Source/web/EditorClientImpl.cpp
@@ -27,10 +27,7 @@
#include "config.h"
#include "EditorClientImpl.h"
-#include "WebAutofillClient.h"
#include "WebFrameImpl.h"
-#include "WebInputElement.h"
-#include "WebInputEventConversion.h"
#include "WebPermissionClient.h"
#include "WebViewClient.h"
#include "WebViewImpl.h"
@@ -38,7 +35,6 @@
#include "core/editing/UndoStep.h"
#include "core/events/KeyboardEvent.h"
#include "core/frame/Frame.h"
-#include "core/html/HTMLInputElement.h"
#include "core/page/EventHandler.h"
#include "core/page/Page.h"
#include "core/page/Settings.h"
@@ -423,34 +419,4 @@ void EditorClientImpl::handleKeyboardEvent(KeyboardEvent* evt)
evt->setDefaultHandled();
}
-void EditorClientImpl::textFieldDidEndEditing(Element* element)
-{
- if (m_webView->autofillClient() && element->hasTagName(HTMLNames::inputTag))
- m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(toHTMLInputElement(element)));
-
- // Notification that focus was lost. Be careful with this, it's also sent
- // when the page is being closed.
-
- // Hide any showing popup.
- m_webView->hideAutofillPopup();
-}
-
-void EditorClientImpl::textDidChangeInTextField(Element* element)
-{
- HTMLInputElement* inputElement = toHTMLInputElement(element);
- if (m_webView->autofillClient())
- m_webView->autofillClient()->textFieldDidChange(WebInputElement(inputElement));
-}
-
-bool EditorClientImpl::doTextFieldCommandFromEvent(Element* element, KeyboardEvent* event)
-{
- if (m_webView->autofillClient() && element->hasTagName(HTMLNames::inputTag))
- m_webView->autofillClient()->textFieldDidReceiveKeyDown(WebInputElement(toHTMLInputElement(element)), WebKeyboardEventBuilder(*event));
-
- // The Mac code appears to use this method as a hook to implement special
- // keyboard commands specific to Safari's auto-fill implementation. We
- // just return false to allow the default action.
- return false;
-}
-
} // namesace WebKit
« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698