Get rid of explict editor dependency from text field

Get rid of explicit editor dependency from text field

This patch removes explicit editor dependency in text field by
 - moves member functions in EditorClientImpl to ChromeClientImpl
 - changes to call SpellChecker function directly rather than via Editor.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162195

[yosin_UTC9, 2013-11-15 07:57:50]

Could you review this patch?
Thanks in advance.

[tkent, 2013-11-15 08:18:06]

lgtm.

The function names are not nice, and the function arguments can be references.
But I think you assume they are not in the scope of this CL.

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
File Source/core/html/forms/TextFieldInputType.cpp (right):

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
Source/core/html/forms/TextFieldInputType.cpp:159:
page->chrome().client().doTextFieldCommandFromEvent(&element(), event);
You can use InputType::chrome().

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
Source/core/html/forms/TextFieldInputType.cpp:451:
page->chrome().client().textDidChangeInTextField(&element());
ditto.

https://codereview.chromium.org/72543005/diff/50001/Source/core/page/ChromeCl...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/72543005/diff/50001/Source/core/page/ChromeCl...
Source/core/page/ChromeClient.h:264: virtual bool
doTextFieldCommandFromEvent(HTMLInputElement*, KeyboardEvent*) { return false; }
nit:
The return value is not used. This can be void.

[yosin_UTC9, 2013-11-15 11:05:59]

PTAL

- Renames function names.
- Use InputType::chrome()

Since try bots have old chromium code and fails compilation. I compiled this
patch on my linux and windows boxes.

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
File Source/core/html/forms/TextFieldInputType.cpp (right):

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
Source/core/html/forms/TextFieldInputType.cpp:159:
page->chrome().client().doTextFieldCommandFromEvent(&element(), event);
On 2013/11/15 08:18:06, tkent wrote:
> You can use InputType::chrome().

Done.

https://codereview.chromium.org/72543005/diff/50001/Source/core/html/forms/Te...
Source/core/html/forms/TextFieldInputType.cpp:451:
page->chrome().client().textDidChangeInTextField(&element());
On 2013/11/15 08:18:06, tkent wrote:
> ditto.

Done.

https://codereview.chromium.org/72543005/diff/50001/Source/core/page/ChromeCl...
File Source/core/page/ChromeClient.h (right):

https://codereview.chromium.org/72543005/diff/50001/Source/core/page/ChromeCl...
Source/core/page/ChromeClient.h:264: virtual bool
doTextFieldCommandFromEvent(HTMLInputElement*, KeyboardEvent*) { return false; }
On 2013/11/15 08:18:06, tkent wrote:
> nit:
> The return value is not used. This can be void.

Done.

[tkent, 2013-11-17 21:46:10]

lgtm

[commit-bot: I haz the power, 2013-11-17 21:46:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/72543005/160001

[commit-bot: I haz the power, 2013-11-17 21:46:26]

Failed to apply patch for Source/core/loader/EmptyClients.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/EmptyClients.h
  Hunk #1 FAILED at 288.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/loader/EmptyClients.h.rej

Patch:       Source/core/loader/EmptyClients.h
Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h
b/Source/core/loader/EmptyClients.h
index
f3b04bc98b13bc801b1726876b48623bf86ddecd..1797db53cbbe02f749193ab9f1df3df509f36709
100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -288,10 +288,6 @@ public:
 
     virtual void handleKeyboardEvent(KeyboardEvent*) OVERRIDE { }
 
-    virtual void textFieldDidEndEditing(Element*) OVERRIDE { }
-    virtual void textDidChangeInTextField(Element*) OVERRIDE { }
-    virtual bool doTextFieldCommandFromEvent(Element*, KeyboardEvent*) OVERRIDE
{ return false; }
-
     TextCheckerClient& textChecker() { return m_textCheckerClient; }
 
     virtual void updateSpellingUIWithMisspelledWord(const String&) OVERRIDE { }

[commit-bot: I haz the power, 2013-11-18 09:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/72543005/280001

[commit-bot: I haz the power, 2013-11-18 12:31:18]

Change committed as 162195