Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 725373003: No need to short circuit the query rect here anymore. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, Justin Novosad
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

No need to short circuit the query rect here anymore. Whatever assertion was triggering in SkRTree.cpp seems to be gone now. BUG=432991 Committed: https://skia.googlesource.com/skia/+/72f92acd47a884b9a1cc961a822a2d4e586b54c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725373003/1
6 years, 1 month ago (2014-11-19 15:20:27 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 15:20:28 UTC) #3
mtklein
I'm going to follow this up with tests to make sure clear() always runs, even ...
6 years, 1 month ago (2014-11-19 15:34:13 UTC) #5
Justin Novosad
On 2014/11/19 15:34:13, mtklein wrote: > I'm going to follow this up with tests to ...
6 years, 1 month ago (2014-11-19 18:37:10 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 18:37:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/72f92acd47a884b9a1cc961a822a2d4e586b54c1

Powered by Google App Engine
This is Rietveld 408576698