content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc - Issue 725353003: Don't pass ProcessHandle through ChildProcessHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc

Issue 725353003: Don't pass ProcessHandle through ChildProcessHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_flash_file_message_filter.h ('k') | content/browser/renderer_host/pepper/pepper_gamepad_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc b/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc

index 5452bafc09c6f4cdbd14db9a239b102cdd9dac80..48da55d5ae71fbadda5d96774cad9f133d92f4e2 100644

--- a/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc

@@ -42,7 +42,7 @@ bool CanCreateReadWrite(int process_id, const base::FilePath& path) {

PepperFlashFileMessageFilter::PepperFlashFileMessageFilter(

PP_Instance instance,

BrowserPpapiHost* host)

- : plugin_process_handle_(host->GetPluginProcessHandle()) {

+ : plugin_process_(host->GetPluginProcess().Duplicate()) {

int unused;

host->GetRenderFrameIDsForInstance(instance, &render_process_id_, &unused);

base::FilePath profile_data_directory = host->GetProfileDataDirectory();

@@ -134,7 +134,7 @@ int32_t PepperFlashFileMessageFilter::OnOpenFile(

}

IPC::PlatformFileForTransit transit_file =

- IPC::TakeFileHandleForProcess(file.Pass(), plugin_process_handle_);

+ IPC::TakeFileHandleForProcess(file.Pass(), plugin_process_.Handle());

ppapi::host::ReplyMessageContext reply_context =

context->MakeReplyMessageContext();

reply_context.params.AppendHandle(ppapi::proxy::SerializedHandle(

@@ -256,7 +256,7 @@ int32_t PepperFlashFileMessageFilter::OnCreateTemporaryFile(