Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 725353003: Don't pass ProcessHandle through ChildProcessHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_child_process_host_impl.h ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_child_process_host_impl.cc
diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc
index b22ee21aae609f6f88923a8728efbe10d379152d..0add19095521f5a90d64c5616b17a094ceb4f563 100644
--- a/content/browser/browser_child_process_host_impl.cc
+++ b/content/browser/browser_child_process_host_impl.cc
@@ -164,13 +164,13 @@ ChildProcessHost* BrowserChildProcessHostImpl::GetHost() const {
return child_process_host_.get();
}
-base::ProcessHandle BrowserChildProcessHostImpl::GetHandle() const {
+const base::Process& BrowserChildProcessHostImpl::GetProcess() const {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DCHECK(child_process_.get())
<< "Requesting a child process handle before launching.";
DCHECK(child_process_->GetProcess().IsValid())
<< "Requesting a child process handle before launch has completed OK.";
- return child_process_->GetProcess().Handle();
+ return child_process_->GetProcess();
}
void BrowserChildProcessHostImpl::SetName(const base::string16& name) {
@@ -255,7 +255,8 @@ void BrowserChildProcessHostImpl::OnBadMessageReceived(
switches::kDisableKillAfterBadIPC)) {
return;
}
- base::KillProcess(GetHandle(), RESULT_CODE_KILLED_BAD_MESSAGE, false);
+ base::KillProcess(child_process_->GetProcess().Handle(),
+ RESULT_CODE_KILLED_BAD_MESSAGE, false);
}
bool BrowserChildProcessHostImpl::CanShutdown() {
« no previous file with comments | « content/browser/browser_child_process_host_impl.h ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698