Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 72533002: [rAc OSX] Restore arrow for top notification. (Closed)

Created:
7 years, 1 month ago by Ilya Sherman
Modified:
7 years, 1 month ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAc OSX] Restore arrow for top notification. I got a little overzealous in deleting code in this file earlier... BUG=319158 TEST=Top notification should have arrow (see bug) R=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_notification_container.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ilya Sherman
7 years, 1 month ago (2013-11-14 07:13:00 UTC) #1
groby-ooo-7-16
LGTM - did I miss that deletion? Sorry!
7 years, 1 month ago (2013-11-14 19:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-14 23:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-15 02:34:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-15 04:26:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224866
7 years, 1 month ago (2013-11-15 07:43:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-15 07:51:05 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224968
7 years, 1 month ago (2013-11-15 09:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-15 22:57:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72533002/1
7 years, 1 month ago (2013-11-16 01:17:39 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:27:05 UTC) #11
Message was sent while issue was closed. 
Change committed as 235701

Powered by Google App Engine
This is Rietveld 408576698