Issue 725303003: Add comments in DropPrivileges() explaining the kernel bug further

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 725303003: Add comments in DropPrivileges() explaining the kernel bug further (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	util/posix/drop_privileges.cc	View	1	2 chunks	+21 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

This is one poor kernel function. Two, actually. I recommend you read it.

6 years, 1 month ago (2014-11-15 00:34:00 UTC) #2

Mark Mentovai

6 years, 1 month ago (2014-11-17 17:24:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d5b28d623654cb9df2d547ef95f914b7bf015f21 (presubmit successful).