Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 725293009: Remove build-time warning from pe_image.cc (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove build-time warning from pe_image.cc This warning has been printed for over 1.5 years on every 64-bit build. Things like this make people blind to warnings. The code does look questionable on 64-bit, and the tests for this code are apparently disabled for 64-bit too. This should be looked at (see bug), but a warning on every build is not how this will happen. BUG=167707, 82385 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/092983ab37029417aa4ecc800e27ebcc05c909b5

Patch Set 1 #

Patch Set 2 : restore todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M base/win/pe_image.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
6 years ago (2014-11-26 17:48:55 UTC) #2
scottmg
lgtm
6 years ago (2014-11-26 18:12:27 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/092983ab37029417aa4ecc800e27ebcc05c909b5 Cr-Commit-Position: refs/heads/master@{#305834}
6 years ago (2014-11-26 18:16:52 UTC) #4
Nico
6 years ago (2014-11-26 18:16:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
092983ab37029417aa4ecc800e27ebcc05c909b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698