Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 725293005: We previously had a setting in chrome defaults but this deprecates that for a command line flag and… (Closed)

Created:
6 years ago by luken
Modified:
6 years ago
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, asvitkine+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171_62
Project:
chromium
Visibility:
Public.

Description

We previously had a setting in chrome defaults but this deprecates that for a command line flag and utility function that always defers to the flag but otherwise returns a default based on operating system. The CL then removes some of the code that depended on the default for a more robust direct check by the render_view_impl. This should also help with some of the CrOS UI bugs that link disambiguation created with views that didn't necessarily initialize their RendererPreferences. BUG=433007, 428163 TBR=jar Review URL: https://codereview.chromium.org/725243002 Cr-Commit-Position: refs/heads/master@{#305385} (cherry picked from commit e23094a2fb86eb15f76caf5b55927d0b7e9ba8f5) Conflicts: chrome/app/generated_resources.grd tools/metrics/histograms/histograms.xml Committed: https://chromium.googlesource.com/chromium/src/+/0fdf608e9339b795f23af3fd04fc7313008cd416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -56 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/defaults.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ui_base_switches_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ui_base_switches_util.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
luken
6 years ago (2014-11-24 20:08:15 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fdf608e9339b795f23af3fd04fc7313008cd416.

Powered by Google App Engine
This is Rietveld 408576698