Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: test/cctest/test-log.cc

Issue 725293003: don't use to-be-deprecated Value::To* without isolate parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 CHECK(false); 489 CHECK(false);
490 } 490 }
491 v8::Handle<v8::Value> result = script->Run(); 491 v8::Handle<v8::Value> result = script->Run();
492 if (result.IsEmpty()) { 492 if (result.IsEmpty()) {
493 v8::String::Utf8Value exception(try_catch.Exception()); 493 v8::String::Utf8Value exception(try_catch.Exception());
494 printf("run: %s\n", *exception); 494 printf("run: %s\n", *exception);
495 CHECK(false); 495 CHECK(false);
496 } 496 }
497 // The result either be a "true" literal or problem description. 497 // The result either be a "true" literal or problem description.
498 if (!result->IsTrue()) { 498 if (!result->IsTrue()) {
499 v8::Local<v8::String> s = result->ToString(); 499 v8::Local<v8::String> s = result->ToString(isolate);
500 i::ScopedVector<char> data(s->Utf8Length() + 1); 500 i::ScopedVector<char> data(s->Utf8Length() + 1);
501 CHECK_NE(NULL, data.start()); 501 CHECK_NE(NULL, data.start());
502 s->WriteUtf8(data.start()); 502 s->WriteUtf8(data.start());
503 printf("%s\n", data.start()); 503 printf("%s\n", data.start());
504 // Make sure that our output is written prior crash due to CHECK failure. 504 // Make sure that our output is written prior crash due to CHECK failure.
505 fflush(stdout); 505 fflush(stdout);
506 CHECK(false); 506 CHECK(false);
507 } 507 }
508 } 508 }
509 isolate->Dispose(); 509 isolate->Dispose();
510 } 510 }
OLDNEW
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698