More SkPicture cleanup

More SkPicture cleanup
 - move field declarations together and pack them a little tighter
 - get rid of fData
 - remove dead code in debugger, including unused SkPicturePlayback subclass

There are now no more long-lived SkPictureData!  (Really, there never were,
but now we don't pretend to support them.)

BUG=skia:

No API changes.
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/c6ad9eefa0f8d0c2ede9884b446c65dde9b04dd1

[mtklein, 2014-11-14 17:30:45]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-14 17:31:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/725143002/40001

[mtklein, 2014-11-14 17:31:58]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-11-14 17:35:35]

mtklein@google.com changed reviewers:
+ robertphillips@google.com
- mtklein@google.com

[robertphillips, 2014-11-17 14:11:45]

lgtm + a nit

https://codereview.chromium.org/725143002/diff/40001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/725143002/diff/40001/src/core/SkPicture.cpp#n...
src/core/SkPicture.cpp:398: SkPicture* SkPicture::Forwardport(const SkPictInfo&
info, const SkPictureData* data) {
newline after '{' and ';' ?

[mtklein, 2014-11-17 14:21:43]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-11-17 14:21:44]

https://codereview.chromium.org/725143002/diff/40001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/725143002/diff/40001/src/core/SkPicture.cpp#n...
src/core/SkPicture.cpp:398: SkPicture* SkPicture::Forwardport(const SkPictInfo&
info, const SkPictureData* data) {
On 2014/11/17 14:11:45, robertphillips wrote:
> newline after '{' and ';' ?

Done.

[mtklein, 2014-11-17 14:21:48]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-17 14:22:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/725143002/60001

[commit-bot: I haz the power, 2014-11-17 14:45:22]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c6ad9eefa0f8d0c2ede9884b446c65dde9b04dd1