Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 725133005: Move serving_dirs to UserStorySet, update user_story_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/__init__.py ('k') | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set.py
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index 51013b233a6434b9b04681bee8e9d413151a1c29..6e29c782612c2412cd69461737278873e17ac5c4 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -23,8 +23,6 @@ class PageSet(user_story_set.UserStorySet):
def __init__(self, file_path=None, archive_data_file='', user_agent_type=None,
make_javascript_deterministic=True, serving_dirs=None,
bucket=None):
- super(PageSet, self).__init__(
- archive_data_file=archive_data_file, cloud_storage_bucket=bucket)
# The default value of file_path is location of the file that define this
# page set instance's class.
# TODO(chrishenry): Move this logic to user_story_set. Consider passing
@@ -35,14 +33,15 @@ class PageSet(user_story_set.UserStorySet):
# Turn pyc file into py files if we can
if file_path.endswith('.pyc') and os.path.exists(file_path[:-1]):
file_path = file_path[:-1]
-
self.file_path = file_path
+
+ super(PageSet, self).__init__(
+ archive_data_file=archive_data_file, cloud_storage_bucket=bucket,
+ serving_dirs=serving_dirs)
+
# These attributes can be set dynamically by the page set.
self.user_agent_type = user_agent_type
self.make_javascript_deterministic = make_javascript_deterministic
- # Convert any relative serving_dirs to absolute paths.
- self._serving_dirs = set(os.path.realpath(os.path.join(self.base_dir, d))
- for d in serving_dirs or [])
@property
def pages(self):
@@ -70,10 +69,6 @@ class PageSet(user_story_set.UserStorySet):
else:
return self.file_path
- @property
- def serving_dirs(self):
- return self._serving_dirs
-
def ReorderPageSet(self, results_file):
"""Reorders this page set based on the results of a past run."""
page_set_dict = {}
« no previous file with comments | « tools/telemetry/telemetry/page/__init__.py ('k') | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698