Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 72513003: [rAc OSX] Fix reversed use of top and bottom padding. (Closed)

Created:
7 years, 1 month ago by Ilya Sherman
Modified:
7 years, 1 month ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAc OSX] Fix reversed use of top and bottom padding. The coordinate system for the window controller is flipped, but the code was treating it as though it was unflipped. BUG=315977 TEST=slightly less padding at top of dialog R=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ilya Sherman
7 years, 1 month ago (2013-11-14 07:07:42 UTC) #1
groby-ooo-7-16
lgtm
7 years, 1 month ago (2013-11-14 19:21:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72513003/1
7 years, 1 month ago (2013-11-14 23:52:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72513003/1
7 years, 1 month ago (2013-11-15 02:33:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72513003/1
7 years, 1 month ago (2013-11-15 04:26:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=190598
7 years, 1 month ago (2013-11-15 07:57:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72513003/1
7 years, 1 month ago (2013-11-15 22:57:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/72513003/1
7 years, 1 month ago (2013-11-16 01:17:05 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 09:33:35 UTC) #9
Message was sent while issue was closed.
Change committed as 235682

Powered by Google App Engine
This is Rietveld 408576698