Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 725113003: Remove dead code in SafeBrowsingDatabaseManager. (Closed)

Created:
6 years, 1 month ago by gab
Modified:
6 years, 1 month ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a2_delegate_constructor
Project:
chromium
Visibility:
Public.

Description

Remove dead code in SafeBrowsingDatabaseManager. SafeBrowsingDatabaseManager::LogPauseDelay() has been dead code since http://crrev.com/169608 when it was moved to UIManager it looks like. BUG=None Committed: https://crrev.com/ce6760690b52af662b5684f24dca6edc20832edf Cr-Commit-Position: refs/heads/master@{#305107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/safe_browsing/database_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gab
Matt PTAL, digging through safe_browsing code and cleaning up as I find things, let me ...
6 years, 1 month ago (2014-11-20 20:09:08 UTC) #2
mattm
lgtm
6 years, 1 month ago (2014-11-20 22:27:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725113003/1
6 years, 1 month ago (2014-11-20 22:29:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 23:14:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 23:14:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce6760690b52af662b5684f24dca6edc20832edf
Cr-Commit-Position: refs/heads/master@{#305107}

Powered by Google App Engine
This is Rietveld 408576698