Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: net/socket/transport_client_socket_unittest.cc

Issue 7251004: Deciding best connection to schedule requests on based on cwnd and idle time (Reopened after revert) (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Syncing to head Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/transport_client_socket_unittest.cc
===================================================================
--- net/socket/transport_client_socket_unittest.cc (revision 90551)
+++ net/socket/transport_client_socket_unittest.cc (working copy)
@@ -277,6 +277,8 @@
rv = sock_->Read(buf, 4096, &callback);
ASSERT_EQ(ERR_IO_PENDING, rv);
+ EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),
+ sock_->NumBytesRead());
CloseServerSocket();
EXPECT_EQ(0, callback.WaitForResult());
}
@@ -309,6 +311,8 @@
// then close the server socket, and note the close.
rv = sock_->Read(buf, 1, &callback);
+ EXPECT_EQ(static_cast<int64>(std::string(kServerReply).size()),
+ sock_->NumBytesRead());
ASSERT_EQ(ERR_IO_PENDING, rv);
CloseServerSocket();
EXPECT_EQ(0, callback.WaitForResult());
@@ -329,9 +333,12 @@
scoped_refptr<IOBuffer> buf(new IOBuffer(16));
rv = sock_->Read(buf, 16, &callback);
EXPECT_TRUE(rv >= 0 || rv == ERR_IO_PENDING);
+ EXPECT_EQ(0, sock_->NumBytesRead());
- if (rv == ERR_IO_PENDING)
+ if (rv == ERR_IO_PENDING) {
rv = callback.WaitForResult();
+ EXPECT_EQ(16, sock_->NumBytesRead());
+ }
EXPECT_NE(0, rv);
}

Powered by Google App Engine
This is Rietveld 408576698